Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart-sass now exits on stdin close #25

Closed
studious opened this issue May 7, 2022 · 1 comment
Closed

dart-sass now exits on stdin close #25

studious opened this issue May 7, 2022 · 1 comment

Comments

@studious
Copy link

studious commented May 7, 2022

This is now a much shorter message than the one I had written about watch not working for dart-sass >= 1.50.0

https://github.com/CargoSense/dart_sass/blob/main/lib/dart_sass.ex#L189

As a test I removed the following as the note describes, recompiled and watch is working again.

    # TODO: Remove when dart-sass will exit when stdin is closed.
    # Link: https://github.com/sass/dart-sass/pull/1411
    path =
      if "--watch" in args and platform() != :windows do
        [script_path() | path]
      else
        path
      end

https://github.com/sass/dart-sass/releases/tag/1.50.0

Closing the standard input stream will now cause the --watch command to stop running.

It looks like you can go ahead and make these changes for watch now.

Thanks

@mcrumm
Copy link
Member

mcrumm commented May 11, 2022

Hi @studious, unfortunately we are not quite there yet. See #26 for more info. Thanks!

@mcrumm mcrumm closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants