Add openshift-ovn-kubernetes NS to permitted NS list in admin actions #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
bitoku and
fahlmant
as code owners
cadenmarchese
approved these changes
Dec 9, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yjst2012
approved these changes
Dec 9, 2024
rajdeepc2792
approved these changes
Dec 11, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
approved these changes
Dec 11, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
E2E has failed with |
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
edisonLcardenas
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-13390
What this PR does / why we need it:
Adds the
openshift-ovn-kubernetesnamespace to the list of OpenShift namespaces permitted for SREs to access using admin API endpoints.Test plan for issue:
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
We will have to see if it works in production or not, we cannot replicate the full SRE admin environment locally without extreme effort.